jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land.
LGTM, thanks for the cleanup. In D77376#1961410 <https://reviews.llvm.org/D77376#1961410>, @kwk wrote: > so I had to update the diff by hand with a bit of trouble. I was told here already it is better to use `git diff -U999999999` as otherwise there is now `Context not available.` during this review. The line 416 comments are even not accessible in the diff now. > or should be put into `SearchFilterByModule::CompUnitPasses` as well? `CompUnitPasses` is using `SymbolContext::comp_unit` which from my DWZ experience is many times not available. So for filtering by `Module`s the `AddressPasses` should be a more safe solution IMO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
