vsk marked an inline comment as done.
vsk added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:790
+ // FIXME: This produces unusable descriptions when the register contains
+ // a pointer to a temporary copy of a struct passed by value.
DIExpression *EntryExpr = DIExpression::get(
----------------
vsk wrote:
> aprantl wrote:
> > What does "unusable" mean? Incorrect? Invalid?
> Should be "incorrect", fixed. It's "unusable" in the sense that the debugger
> will error out trying to evaluate the expression: it will think, "struct Foo
> /is/ the pointer in this register", instead of, "struct Foo is /pointed to/
> by this register".
Actually, this FIXME isn't correct. This is a holdover from an alternative
implementation I had which introduced a DW_OP_LLVM_indirect_entry_value opcode.
I'll remove this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80345/new/
https://reviews.llvm.org/D80345
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
