vsk marked 2 inline comments as done. vsk added inline comments.
================ Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h:151 + IndirectValue = 1 << 1, + CallSiteParamValue = 1 << 2 + }; ---------------- aprantl wrote: > I'm going to be pedantic now: Should this be Indirect instead of > IndirectValue? I.e., can there be non-values (= modifyable locations) that > are indirect? Oh, I wasn't aware "Value" connoted "non-modifiable". In that case, "Indirect" is certainly a better fit: the user can choose to modify the temporary slot in the caller for the indirect param if they'd like. ================ Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h:162 + void adjustLocationKind(const MachineLocation &Loc, + const DIExpression *DIExpr); + ---------------- aprantl wrote: > "adjust" sounds like you could call this more than once. Should it be "set" > or "initialize"? Or even be the constructor? "set" sounds good. The location isn't always available when the DwarfExpression is constructed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80345/new/ https://reviews.llvm.org/D80345 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
