mgorny added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1036 + std::unique_ptr<NativeProcessProtocol> &child_process) { + // Apparently the process has been dealt with by another delegate. + if (!child_process) ---------------- labath wrote: > mgorny wrote: > > labath wrote: > > > You no longer have to worry about that... > > Don't I? The process plugin puts the new instance in an `std::unique_ptr`, > > and passes that to all delegates. Only one delegate can take the pointer > > over. While I don't think we really have a case for multiple delegates > > doing `NewSubprocess()`, I suppose we should check rather than crash. Or > > maybe just put an `assert` for it. > I deleted the multi-delegate thingy in c9cf394f796e1 ;) Ah, cool, I'll get to rebasing shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/ https://reviews.llvm.org/D100191 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits