mgorny marked 2 inline comments as done.
mgorny added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3202-3209
if (!m_current_process ||
(m_current_process->GetID() == LLDB_INVALID_PROCESS_ID)) {
LLDB_LOGF(
log,
"GDBRemoteCommunicationServerLLGS::%s failed, no process available",
__FUNCTION__);
return SendErrorResponse(0x15);
----------------
labath wrote:
> I don't think this makes sense anymore....
Good catch. I must've accidentally reintroduced it in rebase.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3249
+ if (!detached)
+ return SendErrorResponse(Status("PID %" PRIu64 " not traced", pid));
----------------
labath wrote:
> Open question: Should we return an error for a plain `D` packet, if we don't
> have _any_ processes around?
Practically, it probably doesn't matter. However, if client sends `D` without
actually having process attached, then something has probably gone wrong, so
might make sense to return some error.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100191/new/
https://reviews.llvm.org/D100191
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
