On 28 May 2015 at 10:16, Ola Liljedahl <ola.liljed...@linaro.org> wrote:
> On 28 May 2015 at 15:56, Bill Fischofer <bill.fischo...@linaro.org> wrote: > >> This needs to be API-NEXT as it is a change to an API file. >> > I don't see this as an API change, just as a clarification of what is > defined/expected behavior. > I was expecting this behavior already with the current API but I agree > that it should be spelled out clearly. > The rule is that anything that touches "include/odp/api" needs to go via api-next, it can then be cherry picked into master very quickly. The other mechanisms we tried left ambiguity in how to handle the patch becasue api-next and master are currently maintained by Maxim but api-next has extra rules with Petris signoff. I think it would be clearer, faster, simpler if we do split api-next to its own repo and Petri sends pull requests to Maxim every time he is happy for an odp/api change to go in. > > > >> >> On Thu, May 28, 2015 at 7:53 AM, Savolainen, Petri (Nokia - FI/Espoo) < >> petri.savolai...@nokia.com> wrote: >> >>> Reviewed-by: Petri Savolainen <petri.savolai...@nokia.com> >>> >>> >>> > -----Original Message----- >>> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >>> ext >>> > Zoltan Kiss >>> > Sent: Thursday, May 28, 2015 3:19 PM >>> > To: lng-odp@lists.linaro.org >>> > Subject: [lng-odp] [PATCH] api-next: packet_io: clarify what happens >>> when >>> > not all packets are sent >>> > >>> > Currently our examples are not handling this situation as well. >>> > >>> > Signed-off-by: Zoltan Kiss <zoltan.k...@linaro.org> >>> > --- >>> > include/odp/api/packet_io.h | 4 +++- >>> > 1 file changed, 3 insertions(+), 1 deletion(-) >>> > >>> > diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h >>> > index 89356a6..b97b2b8 100644 >>> > --- a/include/odp/api/packet_io.h >>> > +++ b/include/odp/api/packet_io.h >>> > @@ -111,7 +111,9 @@ int odp_pktio_recv(odp_pktio_t pktio, odp_packet_t >>> > pkt_table[], int len); >>> > * @param pkt_table[] Array of packets to send >>> > * @param len length of pkt_table[] >>> > * >>> > - * @return Number of packets sent >>> > + * @return Number of packets sent. If it is less than 'len', the >>> > remaining >>> > + * packets at the end of pkt_table[] are left intact, and caller has >>> to >>> > take >>> > + * care of them. >>> > * @retval <0 on failure >>> > */ >>> > int odp_pktio_send(odp_pktio_t pktio, odp_packet_t pkt_table[], int >>> len); >>> > -- >>> > 1.9.1 >>> > >>> > _______________________________________________ >>> > lng-odp mailing list >>> > lng-odp@lists.linaro.org >>> > https://lists.linaro.org/mailman/listinfo/lng-odp >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
