Yes, but it still doesn't answer my question: do you expect me to resend
the patch with a different subject line?
On 03/06/15 16:22, Bill Fischofer wrote:
The agreed to format for git send-email is --subject-prefix="API-NEXT
PATCH" (or PATCHv2, etc.)
On Wed, Jun 3, 2015 at 10:00 AM, Zoltan Kiss <zoltan.k...@linaro.org
<mailto:zoltan.k...@linaro.org>> wrote:
Hi,
I think there might be some ambiguity here: I understand that the
correct format of subject line is [PATCH API-NEXT], rather than
lower case, I'll do my best not to forget that next time. But do you
expect me to resend the patch with a different subject line? I
assume however picks this up (Maxim?) is already aware of this minor
mistake and picks it up anyway, but I might be wrong.
Or, do you wait for me to send it again with an another patch
implementing this behaviour across our codebase? I thought I should
send it once it gets commited to api-next.
And finally, should the subject line of this next patch start with
[PATCH API-NEXT] as well?
Regards,
Zoli
On 28/05/15 15:28, Bill Fischofer wrote:
We agreed that *any* change to the include/odp directory would be
flagged API-NEXT (avoids having to make decisions). We can then
decide
which to cherry-pick into the mainline on an expedited basis for
simple
things like documentation only changes, but these would be
reviewed on a
case-by-case basis.
On Thu, May 28, 2015 at 9:25 AM, Zoltan Kiss
<zoltan.k...@linaro.org <mailto:zoltan.k...@linaro.org>
<mailto:zoltan.k...@linaro.org <mailto:zoltan.k...@linaro.org>>>
wrote:
Yes, I missed that prefix. Do you want me to resend the patch?
I'll send an another patch to implement this behaviour in
the repo
wherever odp_pktio_send is called. But I think we can't
create a
unit test for it, can we?
On 28/05/15 14:56, Bill Fischofer wrote:
This needs to be API-NEXT as it is a change to an API file.
On Thu, May 28, 2015 at 7:53 AM, Savolainen, Petri (Nokia -
FI/Espoo)
<petri.savolai...@nokia.com
<mailto:petri.savolai...@nokia.com>
<mailto:petri.savolai...@nokia.com
<mailto:petri.savolai...@nokia.com>>
<mailto:petri.savolai...@nokia.com
<mailto:petri.savolai...@nokia.com>
<mailto:petri.savolai...@nokia.com
<mailto:petri.savolai...@nokia.com>>>> wrote:
Reviewed-by: Petri Savolainen
<petri.savolai...@nokia.com <mailto:petri.savolai...@nokia.com>
<mailto:petri.savolai...@nokia.com
<mailto:petri.savolai...@nokia.com>>
<mailto:petri.savolai...@nokia.com
<mailto:petri.savolai...@nokia.com>
<mailto:petri.savolai...@nokia.com
<mailto:petri.savolai...@nokia.com>>>>
> -----Original Message-----
> From: lng-odp
[mailto:lng-odp-boun...@lists.linaro.org
<mailto:lng-odp-boun...@lists.linaro.org>
<mailto:lng-odp-boun...@lists.linaro.org
<mailto:lng-odp-boun...@lists.linaro.org>>
<mailto:lng-odp-boun...@lists.linaro.org
<mailto:lng-odp-boun...@lists.linaro.org>
<mailto:lng-odp-boun...@lists.linaro.org
<mailto:lng-odp-boun...@lists.linaro.org>>>] On Behalf Of ext
> Zoltan Kiss
> Sent: Thursday, May 28, 2015 3:19 PM
> To: lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>>
<mailto:lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>>>
> Subject: [lng-odp] [PATCH] api-next: packet_io:
clarify what
happens when
> not all packets are sent
>
> Currently our examples are not handling this
situation
as well.
>
> Signed-off-by: Zoltan Kiss
<zoltan.k...@linaro.org <mailto:zoltan.k...@linaro.org>
<mailto:zoltan.k...@linaro.org
<mailto:zoltan.k...@linaro.org>>
<mailto:zoltan.k...@linaro.org
<mailto:zoltan.k...@linaro.org>
<mailto:zoltan.k...@linaro.org
<mailto:zoltan.k...@linaro.org>>>>
> ---
> include/odp/api/packet_io.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/odp/api/packet_io.h
b/include/odp/api/packet_io.h
> index 89356a6..b97b2b8 100644
> --- a/include/odp/api/packet_io.h
> +++ b/include/odp/api/packet_io.h
> @@ -111,7 +111,9 @@ int
odp_pktio_recv(odp_pktio_t pktio,
odp_packet_t
> pkt_table[], int len);
> * @param pkt_table[] Array of packets to send
> * @param len length of pkt_table[]
> *
> - * @return Number of packets sent
> + * @return Number of packets sent. If it is
less than
'len', the
> remaining
> + * packets at the end of pkt_table[] are left
intact,
and caller
has to
> take
> + * care of them.
> * @retval <0 on failure
> */
> int odp_pktio_send(odp_pktio_t pktio, odp_packet_t
pkt_table[],
int len);
> --
> 1.9.1
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>>
<mailto:lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>>>
> https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>>
<mailto:lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>>>
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
