I'll take a look. Maybe tomorrow. :) Concerning 2.4.0: Yes. We should. I'm being lazy. Also, just started my own company, so there's that.
Regards, Ivan On 20 April 2014 20:27, Dmitriy Ulyanov <[email protected]> wrote: > Hey Ivan, > > I created 2 pull requests: > https://github.com/apache/logging-log4php/pull/10 > https://github.com/apache/logging-log4php/pull/11 > > Please, check it :) > When can we assemble 2.4.0? > > > 2014-02-24 18:38 GMT+04:00 Ivan Habunek <[email protected]>: > > There's a contributor workfow here: >> http://wiki.apache.org/logging-log4php/Contributing >> >> We're using the so-called "git flow" workflow described here: >> http://nvie.com/posts/a-successful-git-branching-model/ >> >> So you are correct: master contains the latest stable version, and >> develop is where all the work is done. >> >> You should branch from develop. I will merge your changes back into >> develop. And when making a release, develop will be merged into master. >> >> Regards, >> Ivan >> >> >> >> On 24 February 2014 15:29, Dmitriy Ulyanov >> <[email protected]>wrote: >> >>> Thank you for your reply, Ivan. >>> >>> My last question is about development flow: >>> What is the "develop" branch? >>> Is it correct that "master" contains last stable version? >>> From what branch should I fork? From "master"? >>> >>> >>> 2014-02-24 18:12 GMT+04:00 Ivan Habunek <[email protected]>: >>> >>> Sorry, I was not very precise, but the docs should be relatively well >>>> documented, between the README in docs folder, and the Sphinx project >>>> documentation. >>>> >>>> You can look how other appender docs are written: >>>> https://github.com/apache/logging-log4php/tree/develop/docs/appenders >>>> >>>> And please ask if you have any questions. >>>> >>>> Regards, >>>> Ivan >>>> >>>> >>>> On 24 February 2014 14:57, Ivan Habunek <[email protected]> wrote: >>>> >>>>> You can write docs here: >>>>> https://github.com/apache/logging-log4php/tree/develop/docs >>>>> >>>>> Put version 2.4.0 in docs. That will be the next release. We will work >>>>> on 3.0 after. >>>>> >>>>> I will review the code, but when I come back from the trip. If anybody >>>>> has the time and will, they are welcome to do so. >>>>> >>>>> Ivan >>>>> >>>>> >>>>> >>>>> On 24 February 2014 14:51, Dmitriy Ulyanov < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi! >>>>>> >>>>>> I need to know two things: >>>>>> 1. How can i create documentation pages >>>>>> 2. What version should i write in phpdoc? 3.0? >>>>>> >>>>>> Can somebody to review contribution and send comments to me? >>>>>> >>>>>> Next i am going to create Gelf layout with unit tests, may be on >>>>>> next week. >>>>>> >>>>>> >>>>>> On Monday, February 24, 2014, Ivan Habunek <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hey Dmitriy, >>>>>>> >>>>>>> Thank you for the contrubution, it looks great. Unfortunately, I'll >>>>>>> be out of the country until late next month. >>>>>>> >>>>>>> I will have some changes in my working schedule (for the better) and >>>>>>> hope to find some time to work on a release in April. >>>>>>> >>>>>>> Regards, >>>>>>> Ivan >>>>>>> >>>>>>> >>>>>>> On 23 February 2014 22:57, Dmitriy Ulyanov < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi guys, >>>>>>>> >>>>>>>> I redesigned LoggerAppenderAMQP: >>>>>>>> https://github.com/apache/logging-log4php/pull/4/files >>>>>>>> >>>>>>>> It can be used with Graylog2 or logstash. >>>>>>>> >>>>>>>> What you think about it? >>>>>>>> Can we build v.2.4.0?! >>>>>>>> >>>>>>>> -- >>>>>>>> kind regards, >>>>>>>> Dmitry Ulyanov >>>>>>>> PHP Team Lead >>>>>>>> [email protected] >>>>>>>> Wikimart >>>>>>>> www.wikimart.ru >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> kind regards, >>>>>> Dmitry Ulyanov >>>>>> PHP Team Lead >>>>>> [email protected] >>>>>> Wikimart >>>>>> www.wikimart.ru >>>>>> >>>>>> >>>>> >>>> >>> >>> >>> -- >>> kind regards, >>> Dmitry Ulyanov >>> PHP Team Lead >>> [email protected] >>> Wikimart >>> www.wikimart.ru >>> >> >> > > > -- > kind regards, > Dmitry Ulyanov > PHP Team Lead > [email protected] > Wikimart > www.wikimart.ru >
