+1 for a integration test environment with mocked unittests you can't be sure that the entire system works.
2014-05-19 14:17 GMT+02:00 Ivan Habunek <ivan.habu...@gmail.com>: > I agree. I started doing mocking in tests, it's done for the email > appender [1]. We need to do the same for other appenders. > > [1] > https://github.com/apache/logging-log4php/blob/develop/src/test/php/appenders/LoggerAppenderMailTest.php > > Still it would be nice to have an integration test environment where we > could actually test the messages end up in the desired destination (mongo, > mysql or a message queue). > > What do you think? > > Ivan > > > > > On 19 May 2014 11:12, Dmitriy Ulyanov <dmitriy.ulya...@wikimart.ru> wrote: > >> Hi, >> >> maybe we can fix unittests, which used mongo etc? >> I think that custom environment for log4php tests is no good - unittest >> must be unit. >> >> >> 2014-05-19 11:28 GMT+04:00 Florian Semm <florians...@googlemail.com>: >> >> Hey, >>> >>> is the vagrant configuration still an issue? If so I would like to >>> create a setup for the unittest. >>> >>> >>> Regards >>> >>> Florian >>> >>> >>> 2014-05-17 9:33 GMT+02:00 Ivan Habunek <ivan.habu...@gmail.com>: >>> >>> I'm currently working on getting tests passing on TravisCI at the moment: >>>> https://travis-ci.org/apache/logging-log4php >>>> >>>> There's some bug with php5.3 and $_ENV and $_SERVER superglobals which >>>> is proving difficult to track down. >>>> >>>> There's two things that spring to mind: >>>> >>>> 1. How knowledgable are you with vagrant and puppet/chef? I'd love to >>>> have a vagrant configuration which would set up a virtual machine on which >>>> all our unit tests can be run. Currently I need to install a bunch of >>>> services to be able to pass all tests without skipping. >>>> >>>> 2. Go through the issues, see which you'd like fixed for the next >>>> release: >>>> >>>> https://issues.apache.org/jira/browse/LOG4PHP-209?jql=project%20%3D%20LOG4PHP%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC >>>> >>>> I will do no. 2 as well when i get all tests passing on travis. >>>> >>>> Regards, >>>> Ivan >>>> >>>> >>>> On 15 May 2014 20:44, Dmitriy Ulyanov <dmitriy.ulya...@wikimart.ru>wrote: >>>> >>>>> Hi, Ivan! >>>>> >>>>> I see that you merged all my pull requests to develop. That's great >>>>> news! Can i help you with assembling 2.4? >>>>> May be you have some foreground tickets with which i can help? >>>>> Logstash? PSR-3? :) >>>>> >>>>> >>>>> 2014-04-26 21:58 GMT+04:00 Ivan Habunek <ivan.habu...@gmail.com>: >>>>> >>>>> Hi again! >>>>>> >>>>>> I will make you (and the log4php project itself) a promise. >>>>>> >>>>>> On 1.5. I start my new job (self employed). Give me the rest of that >>>>>> week to sort some things out. The week after (starting May 5th) I will >>>>>> review and merge your pull requests. If the quality is as good as I've >>>>>> come >>>>>> to expect from you, I'll start the process of adding you to the team. We >>>>>> can then work together towards releasing 2.4. >>>>>> >>>>>> Regards, >>>>>> Ivan >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On 26 April 2014 13:44, Dmitriy Ulyanov >>>>>> <dmitriy.ulya...@wikimart.ru>wrote: >>>>>> >>>>>>> Hey Ivan! >>>>>>> >>>>>>> How are u? What about review? :) >>>>>>> When can i connect to your team? I think it can improve log4php dev >>>>>>> progress strongly, >>>>>>> because we are using it in our product :) >>>>>>> >>>>>>> >>>>>>> 2014-04-21 23:10 GMT+04:00 Dmitriy Ulyanov < >>>>>>> dmitriy.ulya...@wikimart.ru>: >>>>>>> >>>>>>> Ok, I'll waiting for your comments :) >>>>>>>> Own company is great - congrats! Don't being lazy :) >>>>>>>> >>>>>>>> I hope that we can asseble 2.4.0 in this month. >>>>>>>> >>>>>>>> Until we didn't include graylog2 appenders into library people can >>>>>>>> install it using composer: >>>>>>>> https://packagist.org/packages/dulyanov/log4php-graylog2 >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> 2014-04-20 22:30 GMT+04:00 Ivan Habunek <ivan.habu...@gmail.com>: >>>>>>>> >>>>>>>> I'll take a look. Maybe tomorrow. :) >>>>>>>>> >>>>>>>>> Concerning 2.4.0: Yes. We should. I'm being lazy. Also, just >>>>>>>>> started my own company, so there's that. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Ivan >>>>>>>>> >>>>>>>>> >>>>>>>>> On 20 April 2014 20:27, Dmitriy Ulyanov < >>>>>>>>> dmitriy.ulya...@wikimart.ru> wrote: >>>>>>>>> >>>>>>>>>> Hey Ivan, >>>>>>>>>> >>>>>>>>>> I created 2 pull requests: >>>>>>>>>> https://github.com/apache/logging-log4php/pull/10 >>>>>>>>>> https://github.com/apache/logging-log4php/pull/11 >>>>>>>>>> >>>>>>>>>> Please, check it :) >>>>>>>>>> When can we assemble 2.4.0? >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 2014-02-24 18:38 GMT+04:00 Ivan Habunek <ivan.habu...@gmail.com>: >>>>>>>>>> >>>>>>>>>> There's a contributor workfow here: >>>>>>>>>>> http://wiki.apache.org/logging-log4php/Contributing >>>>>>>>>>> >>>>>>>>>>> We're using the so-called "git flow" workflow described here: >>>>>>>>>>> http://nvie.com/posts/a-successful-git-branching-model/ >>>>>>>>>>> >>>>>>>>>>> So you are correct: master contains the latest stable version, >>>>>>>>>>> and develop is where all the work is done. >>>>>>>>>>> >>>>>>>>>>> You should branch from develop. I will merge your changes back >>>>>>>>>>> into develop. And when making a release, develop will be merged >>>>>>>>>>> into master. >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Ivan >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 24 February 2014 15:29, Dmitriy Ulyanov < >>>>>>>>>>> dmitriy.ulya...@wikimart.ru> wrote: >>>>>>>>>>> >>>>>>>>>>>> Thank you for your reply, Ivan. >>>>>>>>>>>> >>>>>>>>>>>> My last question is about development flow: >>>>>>>>>>>> What is the "develop" branch? >>>>>>>>>>>> Is it correct that "master" contains last stable version? >>>>>>>>>>>> From what branch should I fork? From "master"? >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> 2014-02-24 18:12 GMT+04:00 Ivan Habunek <ivan.habu...@gmail.com >>>>>>>>>>>> >: >>>>>>>>>>>> >>>>>>>>>>>> Sorry, I was not very precise, but the docs should be >>>>>>>>>>>>> relatively well documented, between the README in docs folder, >>>>>>>>>>>>> and the >>>>>>>>>>>>> Sphinx project documentation. >>>>>>>>>>>>> >>>>>>>>>>>>> You can look how other appender docs are written: >>>>>>>>>>>>> >>>>>>>>>>>>> https://github.com/apache/logging-log4php/tree/develop/docs/appenders >>>>>>>>>>>>> >>>>>>>>>>>>> And please ask if you have any questions. >>>>>>>>>>>>> >>>>>>>>>>>>> Regards, >>>>>>>>>>>>> Ivan >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On 24 February 2014 14:57, Ivan Habunek < >>>>>>>>>>>>> ivan.habu...@gmail.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> You can write docs here: >>>>>>>>>>>>>> https://github.com/apache/logging-log4php/tree/develop/docs >>>>>>>>>>>>>> >>>>>>>>>>>>>> Put version 2.4.0 in docs. That will be the next release. We >>>>>>>>>>>>>> will work on 3.0 after. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I will review the code, but when I come back from the trip. >>>>>>>>>>>>>> If anybody has the time and will, they are welcome to do so. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Ivan >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On 24 February 2014 14:51, Dmitriy Ulyanov < >>>>>>>>>>>>>> dmitriy.ulya...@wikimart.ru> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi! >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I need to know two things: >>>>>>>>>>>>>>> 1. How can i create documentation pages >>>>>>>>>>>>>>> 2. What version should i write in phpdoc? 3.0? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Can somebody to review contribution and send comments to me? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Next i am going to create Gelf layout with unit tests, may >>>>>>>>>>>>>>> be on next week. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Monday, February 24, 2014, Ivan Habunek < >>>>>>>>>>>>>>> ivan.habu...@gmail.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hey Dmitriy, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thank you for the contrubution, it looks great. >>>>>>>>>>>>>>>> Unfortunately, I'll be out of the country until late next >>>>>>>>>>>>>>>> month. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I will have some changes in my working schedule (for the >>>>>>>>>>>>>>>> better) and hope to find some time to work on a release in >>>>>>>>>>>>>>>> April. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>> Ivan >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 23 February 2014 22:57, Dmitriy Ulyanov < >>>>>>>>>>>>>>>> dmitriy.ulya...@wikimart.ru> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi guys, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> I redesigned LoggerAppenderAMQP: >>>>>>>>>>>>>>>>> https://github.com/apache/logging-log4php/pull/4/files >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> It can be used with Graylog2 or logstash. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> What you think about it? >>>>>>>>>>>>>>>>> Can we build v.2.4.0?! >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> kind regards, >>>>>>>>>>>>>>>>> Dmitry Ulyanov >>>>>>>>>>>>>>>>> PHP Team Lead >>>>>>>>>>>>>>>>> dmitriy.ulya...@wikimart.ru >>>>>>>>>>>>>>>>> Wikimart >>>>>>>>>>>>>>>>> www.wikimart.ru >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> kind regards, >>>>>>>>>>>>>>> Dmitry Ulyanov >>>>>>>>>>>>>>> PHP Team Lead >>>>>>>>>>>>>>> dmitriy.ulya...@wikimart.ru >>>>>>>>>>>>>>> Wikimart >>>>>>>>>>>>>>> www.wikimart.ru >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> kind regards, >>>>>>>>>>>> Dmitry Ulyanov >>>>>>>>>>>> PHP Team Lead >>>>>>>>>>>> dmitriy.ulya...@wikimart.ru >>>>>>>>>>>> Wikimart >>>>>>>>>>>> www.wikimart.ru >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> kind regards, >>>>>>>>>> Dmitry Ulyanov >>>>>>>>>> PHP Team Lead >>>>>>>>>> dmitriy.ulya...@wikimart.ru >>>>>>>>>> Wikimart >>>>>>>>>> www.wikimart.ru >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> kind regards, >>>>>>>> Dmitry Ulyanov >>>>>>>> PHP Team Lead >>>>>>>> dmitriy.ulya...@wikimart.ru >>>>>>>> Wikimart >>>>>>>> www.wikimart.ru >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> kind regards, >>>>>>> Dmitry Ulyanov >>>>>>> PHP Team Lead >>>>>>> dmitriy.ulya...@wikimart.ru >>>>>>> Wikimart >>>>>>> www.wikimart.ru >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> kind regards, >>>>> Dmitry Ulyanov >>>>> PHP Team Lead >>>>> dmitriy.ulya...@wikimart.ru >>>>> Wikimart >>>>> www.wikimart.ru >>>>> >>>> >>>> >>> >> >> >> -- >> kind regards, >> Dmitry Ulyanov >> PHP Team Lead >> dmitriy.ulya...@wikimart.ru >> Wikimart >> www.wikimart.ru >> > >
