On 22 August 2013 15:49, Tom N Harris <tellia...@whoopdedo.org> wrote: > On Thursday, August 22, 2013 06:27:28 AM Alexey Melnichuk wrote: >> When i compile some module i need to define Windows version(`WINVER` and >> `_WIN32_WINNT` macro). MinGW does not define this macro at all. I think we >> should define this macros in luarocks config. > > No. API compatibility is a function of the source code being built, not the > build system. Different sources will have different compatibility > requirements. Put the necessary compiler flags in your rockspec. If a > developer does not define the appropriate flags to make a rock build on your > system, that's a bug in the rock. It should not be LR's job to babysit poorly > constructed rocks. > > Should LuaRocks also define _POSIX_SOURCE and _LARGEFILE_SOURCE for the > convenience of Linux developers? But what if I want to use a GNU API? Now I > have to argue with LR about what compiler flags to use.
Well, in this case I think it's better to just use the `defines` section in the rockspec (like the LuaSocket rockspec does) and set the most conservative value for WINVER that works for your module. -- Hisham ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Luarocks-developers mailing list Luarocks-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/luarocks-developers
