Dov Feldstern wrote:
José Matos wrote:
On Wednesday 16 May 2007 00:33:52 Dov Feldstern wrote:
*) I would be happy if the very minor attached patch, which marks spaces
which belong to a foreign language in the same manner that
non-whitespace is marked, could go in. This is helpful especially in
bidi situations for understanding where exactly the languages switch.
Georg has approved of the approach (he agrees that spaces should
definitely be marked), but said he doesn't know the relevant code well
enough to vouch for its correctness
(http://permalink.gmane.org/gmane.editors.lyx.devel/81153 --- and there
are more details in that thread). I've been working with this patch
applied since I first submitted it a month ago, and have run into no ill
effects.
This can go.
*) Elazar's math cut&paste issue --- I can't reproduce, see
http://permalink.gmane.org/gmane.editors.lyx.devel/83938
Abdel, what do you think? I trust you judgment in the issue, if the
code is OK with you it can go.
*) my RTL crash fix, see separate discussion at
http://permalink.gmane.org/gmane.editors.lyx.devel/83924
This should go.
Those are the patches that I have in my queue at the moment.
Thanks!
Dov
Thanks for the feedback. :-)
Since I don't have SVN commit access yet, could someone please take care
of this?
I'll send in the patches and comments for the other two (RTL crash and
math cut&paste in a moment)
Thanks!
Dov
Comment for patch rtl_crash fix (available at:
http://permalink.gmane.org/gmane.editors.lyx.devel/83713):
-------------------------------------------------------------
Fix a crash which occurs when RTL flag is turned on.
The crash was being caused by the fact that when moving back from the
beginning of the line to the previous line (by pressing RIGHT in an RTL
paragraph, or LEFT in an LTR one), Bidi metrics for the new line do not
yet exist, but an attempt is made to access them.
Basically, this patch was created by trying to "symmetrically" copy
cursorRight (which seems to work well) to cursorLeft (which was
problematic).
Open issue:
inside cursorLeft, there's a condition from which I commented out two
lines, but I'm not sure why they were in there in the cursorRight case.
I did find that the first one (isLineSeparator) becomes true in a
situation when I actually *do* want to enter that "if" --- that's why I
commented it out. And I commented out the other one by analogy. But I'm
really not sure about this...
See thread http://thread.gmane.org/gmane.editors.lyx.devel/83357/ for
details.
-------------------------------------------------------------
