Dov Feldstern wrote:
Dov Feldstern wrote:
José Matos wrote:
On Wednesday 16 May 2007 00:33:52 Dov Feldstern wrote:
*) I would be happy if the very minor attached patch, which marks
spaces
which belong to a foreign language in the same manner that
non-whitespace is marked, could go in. This is helpful especially in
bidi situations for understanding where exactly the languages switch.
Georg has approved of the approach (he agrees that spaces should
definitely be marked), but said he doesn't know the relevant code well
enough to vouch for its correctness
(http://permalink.gmane.org/gmane.editors.lyx.devel/81153 --- and there
are more details in that thread). I've been working with this patch
applied since I first submitted it a month ago, and have run into no
ill
effects.
This can go.
*) Elazar's math cut&paste issue --- I can't reproduce, see
http://permalink.gmane.org/gmane.editors.lyx.devel/83938
Abdel, what do you think? I trust you judgment in the issue, if the
code is OK with you it can go.
*) my RTL crash fix, see separate discussion at
http://permalink.gmane.org/gmane.editors.lyx.devel/83924
This should go.
Those are the patches that I have in my queue at the moment.
Thanks!
Dov
Thanks for the feedback. :-)
Since I don't have SVN commit access yet, could someone please take
care of this?
I'll send in the patches and comments for the other two (RTL crash and
math cut&paste in a moment)
Thanks!
Dov
comment for math cut&paste patch (attached):
----------------------------------------------------------
Fix for a problem reported by some users, where cut & paste of math
insets in RTL paragraphs is garbled because of parentheses being reversed.
See threads http://permalink.gmane.org/gmane.editors.lyx.devel/83938 and
http://thread.gmane.org/gmane.editors.lyx.devel/83345/focus=83637 for
details.
----------------------------------------------------------
Index: src/Paragraph.cpp
===================================================================
--- src/Paragraph.cpp (revision 18386)
+++ src/Paragraph.cpp (working copy)
@@ -2394,7 +2394,7 @@
os << params().labelString() << ' ';
for (pos_type i = beg; i < end; ++i) {
- value_type const c = getUChar(buffer.params(), i);
+ value_type const c = getChar(i);
if (isPrintable(c))
os.put(c);
else if (c == META_INSET)
