Vincent van Ravesteijn - TNW ha scritto:
I could reproduce this as: New, C-S-f, File->CloseBuffer. The attached
patch (you'll likely get offsets, I have other non-committed changes)
closes the dialog if it is open, when closing the document buffer
(and fixed this use-case). May I commit ?
No. First, it doesn't fix the bug Pavel mentioned (it fixes no bug at
all).
AFAICS, the "bug", here, was that the dialog was shown while no document
was open (and this was supposed to be forbidden by the GUI).
However, if you don't like this fix, I can make a different one: allow
the dialog to be shown even with no documents open (the menu voice will
be active even when starting LyX), but avoid crashes if no buffers are
actually open. Would it be a reasonable fix ?
T.
Second, it doesn't make sense to close the dialog whenever a
buffer is closed. Third, I don't understand why the LASSERT is there in
the first place. You can just remove it AFAICS.
Vincent
