According to john I caused the crashes while fixing the scrolling. That's why I did not backport the fix.

I'd propose the attached fix, which doesn't trigger any (either sporadic and endless) recursive repaint anymore on my Ubuntu 11.04 + qt (4:4.7.2-0ubuntu6.2). If it's ok, then it would apply to BRANCH as well.


No, this will be the right thing to do. Andre told us to do this a while ago, but never did it. We should listen more often to this poor guy.

John.. does this also fix your automatic testcases ?

It's up to Richard whether he takes the risk of putting these last two commits into branch ?


Can you spot any possible negative effect of the patch ?

No, just an unnecessary creation of a QRect object.


Vincent


Reply via email to