Op 19-3-2012 10:00, Vincent van Ravesteijn schreef:
Op 18-3-2012 23:59, uwesto...@lyx.org schreef:
Author: Uwe Stöhr<uwesto...@lyx.org>
Date: Sun, 18 Mar 2012 23:59:03 +0100
New Commit: eeda1c099ed55d6883f8f4f59accd61fc8a4fc64
URL: http://git.lyx.org/?p=lyx.git;a=commit;h=eeda1c099ed55d6883f8f4f59accd61fc8a4fc64

Log:
- INSTALL.Win32: revise and update the description because since Qt 4.8 it mustn't be compiled (and can currently also not without a lot of hacking). Moreover we have now a build script that does all the configuration in one step and we can benefit from the fast Ninja compilation

Signed-off-by: Uwe Stöhr<uwesto...@lyx.org>

 4      Install CMake

-       Install the latest CMake from http://www.cmake.org
+       Install the latest CMakescript from
+ http://sourceforge.net/projects/cmakescript/files/latest/download

 5      Configure

-       - Run the CMake GUI.
+       Open the script file build.bat that you find in your LyX folder
+       C:\LyX\lyx-20\development\cmake
+       with a text editor. Now:

-       - Set the source code path to C:\LyX\lyx-20
-         Set the build path to C:\LyX\lyx-20-build
-         Click Configure and set the generator to Visual Studio 10.
-
-       - Enable LYX_DEPENDENCIES_DOWNLOAD and click Configure.
-         Pre-compiled dependencies will automatically be downloaded.
+       - Change there "D:\Qt\bin" to the path where you installed Qt

-       - Set QT_QMAKE_EXECUTABLE to e.g.
-         C:\Qt\qt-everywhere-opensource-src-4.7.1\bin\qmake.exe
-         and Configure again.
-
-       - Enable the LYX_INSTALL option, set CMAKE_INSTALL_PREFIX to
-         C:\LyX\lyx-20-install and click Configure.
-
-       - Check the Advanced checkbox.
-         Set GETTEXT_MSGFMT_EXECUTABLE to
- C:\LyX\lyx-20-build\msvc2010-deps\deps20\gettext-tools\msgfmt.exe,
-         and do the same for the other gettext tools.
-
-       - Click Generate.
+       - Set the GNUWIN32_DIR to "C:\LyX\lyx-20\msvc2010-deps"
+         (or wherever you have copied the LyX dependencies)
+       - Set the LYX_SOURCE to "C:\LyX\lyx-20"
+         (or wherever you have copied the LyX source files)
+       - Set the LYX_BUILD to "C:\LyX\lyx-20-build"
+         (or wherever you want to store the compilation result)
+
+ (- If you don't want to use the fast compilation mode for debug builds,
+          remove the statement "-GNinja".)

 6      Compile

-       A Microsoft Visual C++ solution should have been generated at
-       C:\LyX\lyx-20-build\lyx.sln
-       Compile the INSTALL project to get a LyX installation in
-       C:\LyX\lyx-20-install
-
-7   Copy dependencies
-
-    Copy
-       - C:\LyX\lyx-20-build\msvc2010-deps\deps20\bin
-       - C:\LyX\lyx-20-build\msvc2010-deps\deps20\imagemagick
-       - C:\LyX\lyx-20-build\msvc2010-deps\deps20\python
-       - C:\LyX\lyx-20-build\msvc2010-deps\deps20\ghostscript
-       - C:\LyX\lyx-20-build\msvc2010-deps\deps20\Resources
-       to C:\LyX\lyx-20-install
+       - Open a MSVC Command prompt via Windows' start menu and switch
+         to the folder
+         C:\LyX\lyx-20\development\cmake
+ - To build LyX with debugging information for development, execute
+         the build script with the command
+         build devel
+       - To build LyX for a release, execute
+         the script with the command
+         build install
+
+7      Copy dependencies
+
+       Copy
+       - C:\LyX\lyx-20\msvc2010-deps\deps20\bin
+       - C:\LyX\lyx-20\msvc2010-deps\deps20\imagemagick
+       - C:\LyX\lyx-20\msvc2010-deps\deps20\python
+       - C:\LyX\lyx-20\msvc2010-deps\deps20\ghostscript
+       - C:\LyX\lyx-20\msvc2010-deps\deps20\Resources
+       to C:\LyX\lyx-20-build\LYX_INSTALLED\bin (install build)
+       or to C:\LyX\lyx-20-build\bin\Debug (debug build)

        And copy from the Qt bin directory
-       (e.g. C:\Qt\qt-everywhere-opensource-src-4.7.1\bin)
+       (e.g. C:\Qt\bin)
        QtCore4.dll
        QtGui4.dll
        QtCore4d.dll (if compiling Debug version)
        QtGui4d.dll (if compiling Debug version)
-       to C:\LyX\lyx-20-install\bin
+       to C:\LyX\lyx-20-build\LYX_INSTALLED\bin (install build)
+       or to C:\LyX\lyx-20-build\bin\Debug (debug build)



Why did you change this ?

IMHO the description is incomplete and not easier. It suddenly requires CMakeScript, it doesn't generate a Visual studio file, it doesn't download the dependencies automatically. And instead of changing the options in the CMake GUI you suddenly prefer to modify a batch file. This means that people won't see the options that can be changed by a single mouseclick.

You should have discussed this before changing it completely.

Vincent



Apparently I did notice this change, and I complained about it, but there was no response. Then I just forgot to revert this change.

Vincent

Reply via email to