Pavel Sanda wrote:
> Richard Heck wrote:
> > Did we decide on 4.5.0? I seem to remember that we did, but we should
> > perhaps make sure everyone still agrees with that decision.
> 
> Yes we did and most ifdefs are already deleted by me together with changes
> in README/INSTALL.

Looked back on the remaining ones:
GuiCharacter.cpp:
// FIXME: hack to work around resizing bug in Qt >= 4.2
// bug verified with Qt 4.2.{0-3} (JSpitzm)
#if QT_VERSION >= 0x040200
        // qt resizes the comboboxes only after show(), so ...
        QDialog::show();
#endif

GuiDocument.cpp:
// FIXME: hack to work around resizing bug in Qt >= 4.2
// bug verified with Qt 4.2.{0-3} (JSpitzm)
#if QT_VERSION >= 0x040200
        docPS->updateGeometry();
#endif

GuiPrefs.cpp:
// FIXME: hack to work around resizing bug in Qt >= 4.2
// bug verified with Qt 4.2.{0-3} (JSpitzm)
#if QT_VERSION >= 0x040200
        prefsPS->updateGeometry();
#endif


Juergen, those are still needed (not sure what bug was that)?


Mac issue, but its not time to delete it now (I guess?)
GuiFontLoader.cpp:
#ifdef Q_WS_MACX
#if QT_VERSION >= 0x040300 //&& QT_VERSION < 0x040800
                        // Workaround for a Qt bug, see 
http://www.lyx.org/trac/ticket/3684
                        // and 
http://bugreports.qt.nokia.com/browse/QTBUG-11145.
                        // FIXME: Check whether this is really fixed in Qt 4.8
                        if (family == "Times" && !font.exactMatch())
                                font.setFamily("Times New Roman");
#endif
#endif


> Pavel

Reply via email to