Op 27-9-2013 23:53, Stephan Witt schreef:
Regarding the details:
* BufferEncoding.cpp is a manual copy of Encoding.cpp
- that's why the wrong comment
- that's why the name of the file
- that's why the superfluous includes
* CharInfo was a private struct
- I've made a class to make it more functional but didn't want to make it public
- It should be used inside Encoding(s) only
- Yes, one can move it to a separate public class with header file
- Yes, that's why the static methods in Encoding.cpp …
Who is we?
Well, I have no other choice than to fix this myself in the coming days and to
prepare the release of beta 2 in the weekend, or to reject this branch for now
and prepare the release of beta 2.
I did it myself.
Thank you, I've merged the branch now, after that I splitted and merged
some commits in more logical building blocks. At least what seemed
logical in my opinion.
You will have to cherry-pick the commit "use
com.apple.compilers.llvm.clang.1_0 for newer Xcode versions" yourself,
because it didn't seem to be related to killing the TEX2LYX define.
Vincent
