On Thu, Apr 14, 2016 at 08:53:24PM +0200, Stephan Witt wrote:
> Am 14.04.2016 um 20:16 schrieb Guillaume Munch <g...@lyx.org>:
> >
> > Le 14/04/2016 19:05, Stephan Witt a écrit :
> >>
> >> Yes, it’s attached. Thanks for testing.
> >>
> >
> >
> > Works well on Linux+qt{4,5}.
> >
> > Two remarks:
> >
> > * isFixedPitch() would be in an anonymous namespace by what I know of LyX's
> > code style.
> > * In my patch I compute typewriterFontName() from typewriterSystemFont.
> > Would you make this change?
>
> Like this one?If you do not set the font to 12 point on Mac, it is too small? I did read the thread and that you tried to configure Qt system settings, but it seems unfortunate to introduce platform-dependent code for something like this. Just to confirm: hard-coding the font size should not change anything for HiDPI right? Doing a grep for "setPointSize" does not show any other examples of hardcoding, if I understand correctly. Why is it only needed here? Scott
signature.asc
Description: PGP signature
