Am Donnerstag, 17. Januar 2019 09:15:03 CET schrieb Kornel Benko <kor...@lyx.org>: > Am Mittwoch, 16. Januar 2019 14:20:37 CET schrieb Scott Kostyshak > <skost...@lyx.org>: > > On Wed, Jan 16, 2019 at 08:10:39PM +0100, Kornel Benko wrote: > > > Am Mittwoch, 16. Januar 2019 13:58:41 CET schrieb Scott Kostyshak > > > <skost...@lyx.org>: > > > > On Wed, Jan 16, 2019 at 07:55:43PM +0100, Kornel Benko wrote: > > > > > > > > > I don't remember why we do not test for lyx20x. > > > > > > > > It is because of the \origin tag (which was introduced later). I think > > > > the test scripts rely on this tag existing for dealing with the > > > > dependencies when copying to the temporary directory. > > > > > > > > Scott > > > > > > > > > > Hm, the 'script' ExportTests.cmake:335 has the line > > > foreach(_lyx_format_num 16 21 22 23) > > > > > > This is independent of origin or not. > > > What I meant is that we do not test for 20x versions. > > > (I did not mean the compilation of the converted lyx file) > > > > Ah now I see. I don't remember the reason either. > > The first entry for lyx21-format is done at e3cd6db4a78. No special reason > to exclude lyx20. I think, we could add this value now. > > > Probably we wanted to > > reduce the time of running all of the tests. > > Looks like we did not take this format as important. > > > We should at some point > > come up with a guideline. For example, we could test validity of .lyx > > files and convergence for the previous 4 version file formats, and test > > (in addition to validity and convergence) compilation of only the > > previous 2. Or something like that. I don't have any strong opinion on > > this. I guess we have to think about what is the best way to catch > > important regressions. > > +1 > > > Scott > > >
In fact, adding lyx20 to the tests leads to:
The following tests FAILED:
3562 - export/examples/beamer_lyx20 (Failed)
3571 - export/examples/beamerlyxexample1_lyx20 (Failed)
3847 - export/examples/localization_test_lyx20 (Failed)
3891 - export/examples/modernCV_lyx20 (Failed)
4891 - export/examples/de/beamer_lyx20 (Failed)
5170 - export/examples/es/modernCV_lyx20 (Failed)
5431 - export/examples/fr/beamer_lyx20 (Failed)
5845 - export/examples/ja/beamer_lyx20 (Failed)
6650 - export/templates/attic/latex8_lyx20 (Failed)
6673 - export/templates/beamer-conference-ornate-20min_lyx20 (Failed)
6710 - export/templates/de_beamer-conference-ornate-20min_lyx20 (Failed)
6800 - export/templates/es_beamer-conference-ornate-20min_lyx20 (Failed)
6818 - export/templates/fr_beamer-conference-ornate-20min_lyx20 (Failed)
6890 - export/templates/ja_beamer-conference-ornate-20min_lyx20 (Failed)
6977 - export/templates/maa-monthly_lyx20 (Failed)
7175 - export/templates/revtex4-1_lyx20 (Failed)
This is not so bad. Committing now (at 5435b900)
Kornel
signature.asc
Description: This is a digitally signed message part.
