On Thu, 17 Jan 2002, Allan Rae wrote: > On Thu, 17 Jan 2002, Juergen Vigna wrote: > > > > > On 17-Jan-2002 Allan Rae wrote: > > > > > Sorry, the minipages now work almost as correct as they should. > > > When I make the second minipage 45% (instead of 100%) the two > > > minipages are no longer placed in the same row. > > > > I don't see this here, sorry! > [...]
> That line is text.C:484 (currently CVS has this) > > if (!need_break_row && !inset_owner > ==> && p.bv->text->status() == CHANGED_IN_DRAW) { > Row * prev = p.row->previous(); I was thinking about this after having a shower and I know what the problem is. It's a couple of lines lower than this and should be made to read something like this: if (prev->next != p.row) { need_break_row = prev; p.row = 0; // this is currently p.row = prev; } else { need_break_row = p.row; } That's in LyXText::drawInset(); It currently sets need_break_row = prev->next() which is 0 for the last line of a file (or the only line of a file in the minipage testcase). Sorry about that. I didn't have a clue what need_break_row or refresh_row were about and now I still don't but I know need_break_row is wrong. Allan. (ARRae)