On Wed, Aug 13, 2003 at 12:28:25AM +0100, John Levon spake thusly: > > On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote: > > > Here's an update. Two bugs squashed, an off-by-one in ColorHandler > > Generally seems OK. Problems : > > 1) the default color is black. This "should" give a black background. It > doesn't. There's also no indication in the dialog what the colour is > used for. It should default to "transparent" somehow, and some mention > of background colour should be made.
Fixed. > I don't know how to indicate it's only used inside lyx. I tried to... have a look. > Color changes do not update the document. The Graphics Context cache in ColorHandler remembers old colours like an elephant... OK, should be allright now. (This was seriously nontrivial!) > 2) when closing a branch and a cursor is inside, the cursor is not > reset. I do not understand what you mean. If you mean: - place cursor in inset - close inset - visible cursor lands on top of button then this is a problem with all insets, not just branches... if they are at the beginning of an indented paragraph. If you mean something else, please give me a clearer description so I can reproduce it. Better still, provide a fix... > 3) I notice a wart of submenus growing halfway down the insert menu. All > items with submenus should be in the top section (probably below "List / > TOC"). Same goes for Note. (Rationale: unwanted submenus flashing up are > annoying. Grouping them makes it easier to avoid, as it's just one > region then). Fixed. I left this intentionally alone as it is your turf and a separate issue ;-) > 4) "Branch name" in the dialog is missing a colon. I'm not sure that > "name" part is a good idea either. I think I'd prefer "Branch:". Fixed. > 5) Adding a branch doesn't update the branch inset dialog combo box ! Fixed... took a little while :-( > 2), 3), and 5) are must-fixes for me. > > I think I'd probably want a different dialog layout etc. for Qt > frontend for the document entries. Perhaps even a separate dialog > from Document->Settings. I need to think on that one. > > I also have a more general problem with the use of insets. Consider : > > 1. We like Steve. > > 2. He's OK. > > 3. (TOP SECRET BRANCH) Actually we're going to kill him > > 4. Give him a raise. ;-) > It's simply impossible to do that with the current architecture. I don't > know if we can easily fix this though, I would not worry about it. > > regards > john See attached. Against CVS of an hour ago. Martin -- Martin Vermeer [EMAIL PROTECTED] Helsinki University of Technology Dept. of Surveying, Inst. of Geodesy P.O. Box 1200, FIN-02015 HUT, Finland :wq
br8.diff.gz
Description: application/gunzip
pgp00000.pgp
Description: PGP signature