On Thu, Oct 16, 2003 at 11:14:31AM +0200, Lars Gullik Bjønnes wrote: > So, dammit, 1.4.0 will not be released tomorror or the week after > that. So a tiny effort to fix this would be nice.
These problems will vanish with a global cursor as there won't be 'unitialized' LyXCursor 'slices' left in LyXText. I am trying to get a global cursor. This is more than a 'tiny effort' as far as I can tell. > | This is not really 'blatantly wrong' and a reason for an assert. In fact > | the pre-parlist code simply ignored that situation with using a 0 > | Paragraph* in the 'uninitialized cursor'. We could mimic old behaviour > | by initializing the paragraph to 0 in the LyXCursor constructor and get > | exactly pre-parlist behaviour (i.e. no crashes, no warning). > > > | Getting the warning, however, is a means to detect bad logic. And while > | the old code simply ignored it and the current code crashes I thought it > | would be better to fix it. > > by pretending it is '0'? Is that really a fix? It makes the cursor always 'valid' and restores 1.3.0 functionality. Call that however you like, I am not in the mood for semantic games. Note, however, that e.g. searching does not really need a valid cursor during the search but only need to set one in the end. The current insistence on a valid cursor is just another sign of a broken architecture ('local' cursors, and the ability to do 'interesting things' only in locked insets...). > | I need the warning for that and 1.4.0cvs needs users. We can have both. > | Were is the _real_ problem? > > Will you act on every warning, not that you don't have to? Warnins annoy me sufficiently. Andre'