Lars Gullik Bjønnes wrote:
> Why a separate from_ascii really? If it is ascii, then it is also
> utf-8.
Sure. I made it separate because that makes the intention very clear: If we
know that it is ASCII we don't need a more costly utf8 conversion. And
from_ascii is not supposed to go away as from_utf8 is.
> +docstring const from_ascii(std::string const & ascii)
> +{
> + // For now we assert on ascii range. Otherwise we could do
> + // return docstring(ascii.begin(), ascii.end());
>
> Do that check first, then just use the above simple construction.
OK.
> Quite ok, the resto fo the patch.
I'll commit an updated one tonight.
Georg
