El vie, 23-10-2009 a las 09:39 +0300, Kimmo Hämäläinen escribió:
> 
> 
> > it's a good idea to check for the existence of the screenshot and
> > recreate it if necessary.
> 
> Now that the function is missing this argument (bad design). 

What do you mean by bad design?

> We should
> add some API for creating the screenshot _only if_ it does not exist.
> Because the place where the screenshot is stored, is not really public
> information.

Well, the hildon API is 

 void hildon_gtk_window_take_screenshot   (GtkWindow *window,
                                           gboolean take);

If @take is %FALSE, the screenshot for @window is destroyed.

The only thing that this method is doing in the client side is to set a
property in the window. When @take is %TRUE, it's the desktop the one
who should actually verify whether the screenshot exists already and
create it or not. That doesn't really require new API, just that the
desktop does the full job instead of delegating the responsibility to do
black voodoo to the client application.

Of course a lot of applications are already checking for the existence
of the screenshot, but changing the semantics this way shouldn't really
hurt.

Claudio

_______________________________________________
maemo-developers mailing list
maemo-developers@maemo.org
https://lists.maemo.org/mailman/listinfo/maemo-developers

Reply via email to