On Wed, Apr 17, 2002 at 09:11:24PM +0200, Andreas J. Koenig wrote:
> This patch seems to fix it, needs confirmation by Schwern.

This shouldn't do much but throw several "odd number of elements in
hash" warnings. _maniskip() takes a hash, not file + hash.

You're in the right area, though.  I'm looking at that:

    my $mfile ||= "$MANIFEST.SKIP" 

and going "Huh?"


> --- /usr/sources/perl/repoperls/perl-5.7.3@15975/lib/ExtUtils/Manifest.pm     Wed 
>Apr 17 17:48:25 2002
> +++ /usr/local/perl-5.7.3@15975/lib/5.7.3/ExtUtils/Manifest.pm        Wed Apr 17 
>21:07:20 2002
> @@ -206,10 +206,10 @@
>  
>  # returns an anonymous sub that decides if an argument matches
>  sub _maniskip {
> -    my (%args) = @_;
> +    my($mfile, %args) = @_;
>  
>      my @skip ;
> -    my $mfile ||= "$MANIFEST.SKIP";
> +    $mfile ||= "$MANIFEST.SKIP";
>      local *M;
>      open M, $mfile or open M, $DEFAULT_MSKIP or return sub {0};
>      while (<M>){


-- 

Michael G. Schwern   <[EMAIL PROTECTED]>    http://www.pobox.com/~schwern/
Perl Quality Assurance      <[EMAIL PROTECTED]>         Kwalitee Is Job One
Remember, any tool can be the right tool.
    -- Red Green

Reply via email to