On Thursday, April 18, 2002, at 06:42 PM, Andreas J. Koenig wrote: > The patch that broke the camel's neck was 15599 and when I read that, > I recognize what you describe as your patch. It broke the original > semantics of manifind which was documented: > > manifind() returns a hash reference. The keys of the hash are the > files found below the current directory. > > I'm using manifind in programs as a handy wrapper myself. They will > break with this change.
Okay, I give. > If you want a faster mkmanifest() that works without manifind due to > performance considerations, you should probably write a > fastmkmanifest() without touching manifind(). It seems like it would be better to write a fastmanifind(), and have mkmanifest() use that instead of manifind(). It ends up throwing all the SKIP files away anyway. >> That line should be > >> ^/Makefile$ > >> instead, right? > > No. I don't quite understand that. If MANIFEST.SKIP is skipping those files, then how did they end up in MANIFEST? Or if they're not in MANIFEST, why is manicheck() complaining about them? -Ken
