[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854904#action_12854904
 ] 

Vinay Kumar Thota commented on MAPREDUCE-1646:
----------------------------------------------

Shall the limit be raised slightly? Say 2 mins? 

I agreed with you for increasing the time slightly 2 mins. However, If a task 
is not started almost 1min, in that case there might be some issue with task 
tracker.As per my opinion whenever job started, atleast one task should be 
started with in fraction of seconds. Overall I am saying, in  these condition 
situations we failing the test and giving the proper message instead of 
increasing the time.

'Good citizen' test should be unrelated to environment as much as possible. If 
you can provide some special settings in the test config - you should do so, If 
test requires a particular environment to exist at the moment of a test 
execution and such env. setting doesn't exist then the test in question should 
fail with proper and meaningful error message. E.g. a person who runs tests 
shouldn't be guessing the required environment.

I agreed with you, however currently I have checked all the possible conditions 
in the test. As per your log,it say some class is missing 
(com.hadoop.compression.lzo.LzoCodec not found) and it seems to me some library 
file is missing at your environment,so that test is failing.

I had been running the test couple of times on 5 node multi cluster and it 
passes consistently every time. Please check the attached log 
file(TEST-org.apache.hadoop.mapred.TestTaskKilling.txt).


> Task Killing tests
> ------------------
>
>                 Key: MAPREDUCE-1646
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1646
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: TaskKilling_1646.patch, TaskKilling_1646.patch, 
> TaskKilling_1646.patch, TEST-org.apache.hadoop.mapred.TestTaskKilling.txt, 
> TEST-org.apache.hadoop.mapred.TestTaskKilling.txt
>
>
> The following tasks covered in the test.
> 1. In a running job, kill a task and verify the job succeeds.
> 2. Setup a job with long running tasks that write some output to HDFS. When 
> one of the tasks is running, ensure that
> the output/_temporary/_attempt-id directory is created. Kill the task. After 
> the task is killed, make sure that the
> output/_temporary/_attempt-id directory is cleaned up.
> 3. Setup a job with long running tasks that write some output to HDFS. When 
> one of the tasks is running, ensure that
> the output/_temporary/_attempt-id directory is created. Fail the task by 
> simulating the map. After the task is failed,
> make sure that the output/_temporary/_attempt-id directory is cleaned up. The 
> important difference we are trying to
> check is btw kill and fail, there would a subtle difference.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to