[
https://issues.apache.org/jira/browse/MAPREDUCE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855854#action_12855854
]
Vinay Kumar Thota commented on MAPREDUCE-1646:
----------------------------------------------
Both the functions are two different tests and I am thinking its not good idea
to combine two functions into one because both the tests has two different ways
for killing and failing the task. For failing the task, we are defining a
mapper to fail the task by itself but for killing the task , there is no user
define mapper and killing the task by passing the task attempt id. So I don't
think for combining the both the functions into one is a good idea .Also both
are two different scenarios,so finally one more thing,if you combine both the
functions into one, it will become tedious to debug for user also. In my
opinion maintaining two different functions, i am mean two different tests
would be better.
> Task Killing tests
> ------------------
>
> Key: MAPREDUCE-1646
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1646
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: test
> Reporter: Vinay Kumar Thota
> Assignee: Vinay Kumar Thota
> Attachments: TaskKilling_1646.patch, TaskKilling_1646.patch,
> TaskKilling_1646.patch, TEST-org.apache.hadoop.mapred.TestTaskKilling.txt,
> TEST-org.apache.hadoop.mapred.TestTaskKilling.txt
>
>
> The following tasks covered in the test.
> 1. In a running job, kill a task and verify the job succeeds.
> 2. Setup a job with long running tasks that write some output to HDFS. When
> one of the tasks is running, ensure that
> the output/_temporary/_attempt-id directory is created. Kill the task. After
> the task is killed, make sure that the
> output/_temporary/_attempt-id directory is cleaned up.
> 3. Setup a job with long running tasks that write some output to HDFS. When
> one of the tasks is running, ensure that
> the output/_temporary/_attempt-id directory is created. Fail the task by
> simulating the map. After the task is failed,
> make sure that the output/_temporary/_attempt-id directory is cleaned up. The
> important difference we are trying to
> check is btw kill and fail, there would a subtle difference.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
