[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170674#comment-13170674
 ] 

Jason Lowe commented on MAPREDUCE-3360:
---------------------------------------

This looks like a duplicate of MAPREDUCE-3271.

A few comments on the patch:

1.  Should the "Total Nodes" column header on the nodes pages be changed to 
something like "Active Nodes"?  Currently it sounds like it should be a count 
of all the nodes (active or not) associated with the cluster, but it's only 
counting the active nodes.  Related to this, should there be a page listing all 
nodes regardless of state (i.e.: a real Total Nodes page)?

2.  There will be bookkeeping issues for the inactive nodes when a single host 
has been configured with multiple nodemanager instances.  (A bit odd, but 
possible to setup.)  Since the inactive nodes are tracked only by hostname, we 
will remove a node from the inactive list when a new nodemanager appears on a 
different port.  Probably best to track that issue in a separate JIRA.  There 
are other issues with that setup, e.g.: inability to detect redundant 
nodemanager launches, limit nodemanager instances, etc.

3.  Maintenance: ClusterMetrics.decr(RMNodeState) doesn't handle all the node 
states.  May be better to just to remove this method and have the one place 
it's used do the switch.

3.  Nit: The "N/A" web address for inactive nodes shouldn't be a hyperlink, 
since it doesn't go anywhere useful.
                
> Provide information about lost nodes in the UI.
> -----------------------------------------------
>
>                 Key: MAPREDUCE-3360
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3360
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 0.23.0
>         Environment: NA
>            Reporter: Bh V S Kamesh
>         Attachments: MAPREDUCE-3360.patch, lostNodes.png
>
>
> Currently there is no information provided about *lost nodes*. Provide 
> information in the UI. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to