[
https://issues.apache.org/jira/browse/MAPREDUCE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181729#comment-13181729
]
Jason Lowe commented on MAPREDUCE-3360:
---------------------------------------
Thanks for adding the web services support. A few issues I noticed:
1) Copy-n-paste error on line 234 of TestRMWebServicesNodes.java in
testNodesQueryStateLost():
{code}
WebServicesTestUtils.checkStringMatch("nodeHTTPAddress", rmNode
.getState().toString(), info.getString("state"));
{code}
{{"nodeHTTPAddress"}} should be {{"state"}}. This also occurs on line 264.
2) In testNodesQueryStateLost() the test is assuming that the order of nodes
returned is deterministic, but I'm not sure that's guaranteed by the API. In
addition, it simply checks if the node ID is what it's looking for, and if it
isn't, it silently allows the test to pass. Since both nodes should be lost at
this point in the test, we could just loop over the returned nodes and verify
we see the fields we expect for each node entry.
3) In testSingleNodeQueryStateLost() the code similarly checks for the expected
node ID. If it doesn't match it should fail.
> Provide information about lost nodes in the UI.
> -----------------------------------------------
>
> Key: MAPREDUCE-3360
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3360
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 0.23.0
> Environment: NA
> Reporter: Bhallamudi Venkata Siva Kamesh
> Assignee: Bhallamudi Venkata Siva Kamesh
> Priority: Critical
> Attachments: LostNodes.png, MAPREDUCE-3360-1.patch,
> MAPREDUCE-3360-2.patch, MAPREDUCE-3360-3.patch, MAPREDUCE-3360-4.patch,
> MAPREDUCE-3360.patch, lostNodes.png
>
>
> Currently there is no information provided about *lost nodes*. Provide
> information in the UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
