[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175843#comment-13175843
 ] 

Bhallamudi Venkata Siva Kamesh commented on MAPREDUCE-3360:
-----------------------------------------------------------

bq. we should either remove the "Rebooted Nodes" column from the metrics since 
nodes will never be in the REBOOT state or add code to support the REBOOT 
state.For example, we'd have to update the StateMachineFactory in 
RMNodeImpl.java to transition to the REBOOT state instead of the LOST state 
when the REBOOTING event is delivered.
 
I *think* each metric denotes a specific reason for node's inactive state,so, 
updating the StateMachineFactory than removing the *Rebooted Nodes* column from 
the metrics seems appropriate.

bq.  And in the code you ran across, we'd probably not want to increment the 
reboot count if the node is in the inactive nodes map already. If it wasn't in 
the map, we'd increment the reboot counter and add it to the inactive node map.

I *think*, updating the *REBOOT* metrics, as I mentioned in my earlier comment, 
seems to be unnecessary as updation of correct metrics has already been done 
while removing the node due to *LOST* event.

any comments?
                
> Provide information about lost nodes in the UI.
> -----------------------------------------------
>
>                 Key: MAPREDUCE-3360
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3360
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 0.23.0
>         Environment: NA
>            Reporter: Bhallamudi Venkata Siva Kamesh
>            Priority: Critical
>         Attachments: LostNodes.png, MAPREDUCE-3360-1.patch, 
> MAPREDUCE-3360.patch, lostNodes.png
>
>
> Currently there is no information provided about *lost nodes*. Provide 
> information in the UI. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to