[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182656#comment-13182656
 ] 

Thomas Graves commented on MAPREDUCE-3360:
------------------------------------------

A couple of comments:

RMWebServices.java
- minor nit: I would prefer the web services to output empty string rather then 
"N/A" for the nodeHttpAddress. It seems more programmatic and I tried to make 
that change consistent throughout.
- I think you can use the nid.getHost() instead of doing the split on ":" to 
get the hostName.

MetricsOverviewTable.java
- I think we need to change ClusterMetricsInfo.java to match if this field is 
Active instead of Total.  It has a field totalNodes which appears to really be 
active nodes. So I think we should add a new activeNodes field and then make 
totalNodes the true total nodes of the cluster -> active + rebooted + lost + 
decommissioned.

ClusterMetrics.java
- do we want to change the heading output to match active nodes?
  @Metric("# of NMs") MutableGaugeInt numNMs;



                
> Provide information about lost nodes in the UI.
> -----------------------------------------------
>
>                 Key: MAPREDUCE-3360
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3360
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 0.23.0
>         Environment: NA
>            Reporter: Bhallamudi Venkata Siva Kamesh
>            Assignee: Bhallamudi Venkata Siva Kamesh
>            Priority: Critical
>         Attachments: LostNodes.png, MAPREDUCE-3360-1.patch, 
> MAPREDUCE-3360-2.patch, MAPREDUCE-3360-3.patch, MAPREDUCE-3360-4.patch, 
> MAPREDUCE-3360-5.patch, MAPREDUCE-3360.patch, lostNodes.png
>
>
> Currently there is no information provided about *lost nodes*. Provide 
> information in the UI. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to