[
https://issues.apache.org/jira/browse/MAPREDUCE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656347#comment-13656347
]
Mayank Bansal commented on MAPREDUCE-5233:
------------------------------------------
Thanks Zhijie for the review.
1. In setState, it is good to add default block to handle the case that the int
param is not within the value domain of the State enum.
>> Looks like its not needed as by default i m returning the default value.
2. getMapredJobID is changed to return String to be compatible with 1.x. Is it
good to keep a similar function (maybe called "getMapredJobId") to still return
the JobID object? In case the function will be potentially used in 2.x.
>> Good Idea , Fixed it.
3. I'm not clear why getJobID will be called twice with the patch. Perhaps some
inline comments here to explain the two usages?
- verify(mockjob).getJobID();
+ verify(mockjob,times(2)).getJobID();
>> Fixed it in latest patch
Thanks,
Mayank
> Functions are changed or removed from Job in jobcontrol
> -------------------------------------------------------
>
> Key: MAPREDUCE-5233
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5233
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Fix For: 2.0.5-beta
>
> Attachments: MAPREDUCE-5233-trunk-1.patch,
> MAPREDUCE-5233-trunk-2.patch, MAPREDUCE-5233-trunk-3.patch
>
>
> The functions are removed from Job in jobcontrol:
> 1. setMapredJobID(String)
> 2. setState(int)
> The function signatures are changed:
> 1. addDependingJob(ControlledJob)
> 2. getMapredJobID()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
