[
https://issues.apache.org/jira/browse/MAPREDUCE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658752#comment-13658752
]
Zhijie Shen commented on MAPREDUCE-5233:
----------------------------------------
I'm not sure if it is good to make WAITING the default value, and map invalid
integer value to WAITING. Maybe add one more enum, named UNDEFINED?
Please add @Test (timeout = xxxx) before:
{code}
public void testJobState() throws Exception {
{code}
IMHO, it is good to test String getMapredJobID() as well, though it is much
stragithforward.
> Functions are changed or removed from Job in jobcontrol
> -------------------------------------------------------
>
> Key: MAPREDUCE-5233
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5233
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-5233-trunk-1.patch,
> MAPREDUCE-5233-trunk-2.patch, MAPREDUCE-5233-trunk-3.patch,
> MAPREDUCE-5233-trunk-4.patch
>
>
> The functions are removed from Job in jobcontrol:
> 1. setMapredJobID(String)
> 2. setState(int)
> The function signatures are changed:
> 1. addDependingJob(ControlledJob)
> 2. getMapredJobID()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
