[
https://issues.apache.org/jira/browse/MAPREDUCE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659208#comment-13659208
]
Vinod Kumar Vavilapalli commented on MAPREDUCE-5233:
----------------------------------------------------
This is another case where 0.23 will be broken. Will mark it as incompatible.
Changing {{JobID getMapredJobID()}} to {{String getMapredJobID}} itself breaks
0.23. Don't think we have a choice. Retaining {{JobID getMapredJobId()}} won't
help, but worth leaving it.
So, let's do this:
- Change {{JobID getMapredJobID()}} to {{JobID getMapredJobId()}} in
ControlledJob.
- Add {{getMapredJobID()}} to Job, as that's where it is really needed.
- Add {{setMapredJobID(String mapredJobID)}} also to Job similarly. And make
it simply call {{setAssignedJobID(JobID mapredJobID)}}, which semantically was
what 1.x was doing. We cannot add this new API in ControlledJob as
fundamentally you cannot change JobIDs. Even in Job, this API will be a no-op -
a clear behavior change, definitely change the javadoc accordingly and may be
we should document it on the documentation JIRA.
- Similarly add {{setState(int)}} but make it a no-op. We don't want users to
reach in and mess with the state. Definitely change javadoc and may be also a
comment on documentation JIRA.
Based on this please, change the test-cases as well. We need to specifically
validate the Job APIs that are added and the ControlledJob API that changes.
> Functions are changed or removed from Job in jobcontrol
> -------------------------------------------------------
>
> Key: MAPREDUCE-5233
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5233
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-5233-trunk-1.patch,
> MAPREDUCE-5233-trunk-2.patch, MAPREDUCE-5233-trunk-3.patch,
> MAPREDUCE-5233-trunk-4.patch
>
>
> The functions are removed from Job in jobcontrol:
> 1. setMapredJobID(String)
> 2. setState(int)
> The function signatures are changed:
> 1. addDependingJob(ControlledJob)
> 2. getMapredJobID()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
