[ https://issues.apache.org/jira/browse/MAPREDUCE-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149092#comment-15149092 ]
Wangda Tan commented on MAPREDUCE-6579: --------------------------------------- Apologize for the delays, I was on vacation in recent a couple of weeks. Went through discussions, For concerns from [~jlowe]: bq. It's a little unfortunate that YARN-3946 started putting non-fatal messages into what is typically an app-driven diagnostic repository.... bq. It seems these new messages only make sense to report when the job is active and are mostly noise afterwards. As [mentioned|https://issues.apache.org/jira/browse/MAPREDUCE-6579?focusedCommentId=15146537&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15146537] by [~Naganarasimha], diagnostic message added by YARN-3946 only exists before AM registers to RM, and it will be cleaned up after AM registers. So I think this will not pollute the final failure message from app. The only issue I can see is MR assumes diagnostic message == failure message: To make changes of YARN-3946 backward compatible to MR apps, I think 05-patch is the simplest way to fix the problem: it avoid taking any field modified by YARN-3946 and keeps everything else same. Thoughts? [~Naganarasimha Garla]/[~ajisakaa]/[~sunilg]. > JobStatus#getFailureInfo should not output diagnostic information when the > job is running > ----------------------------------------------------------------------------------------- > > Key: MAPREDUCE-6579 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6579 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test > Reporter: Rohith Sharma K S > Assignee: Akira AJISAKA > Priority: Blocker > Attachments: MAPREDUCE-6579.01.patch, MAPREDUCE-6579.02.patch, > MAPREDUCE-6579.03.patch, MAPREDUCE-6579.04.patch, MAPREDUCE-6579.05.patch, > MAPREDUCE-6579.06.patch > > > From > [https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt] > TestNetworkedJob are failed intermittently. > {code} > Running org.apache.hadoop.mapred.TestNetworkedJob > Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 81.131 sec > <<< FAILURE! - in org.apache.hadoop.mapred.TestNetworkedJob > testNetworkedJob(org.apache.hadoop.mapred.TestNetworkedJob) Time elapsed: > 30.55 sec <<< FAILURE! > org.junit.ComparisonFailure: expected:<[[Tue Dec 15 14:02:45 +0000 2015] > Application is Activated, waiting for resources to be assigned for AM. > Details : AM Partition = <DEFAULT_PARTITION> ; Partition Resource = > <memory:8192, vCores:16> ; Queue's Absolute capacity = 100.0 % ; Queue's > Absolute used capacity = 0.0 % ; Queue's Absolute max capacity = 100.0 % ; ]> > but was:<[]> > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.mapred.TestNetworkedJob.testNetworkedJob(TestNetworkedJob.java:174) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)