[
https://issues.apache.org/jira/browse/MAPREDUCE-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151624#comment-15151624
]
Naganarasimha G R commented on MAPREDUCE-6579:
----------------------------------------------
Thanks [~wangda] for the reply,
Modifications in {{JobStatus.getFailureInfo}} will ensure that neither AM(/Job)
nor RM can return diagnostic info when the job is successful, but modifications
i suggested in {{NotRunningJob.getDiagnostics}} tries to take care only of
avoiding the RM diagnostics when app is not launched.
As i said earlier its ideal to go for {{JobStatus.getFailureInfo}}
modifications but not sure about the compatibility i.e. AM/Job is purposefully
setting the diagnostic message even when the job is running or job has
succeeded.
Also IMO either one of the modifications is sufficient based on the scope what
we are going to decide.
thoughts?
bq. Diagnostic message returned only job is failed or killed In the 07 patch, I
think we should at least include finished state.
As per the description of *YarnApplicationState.FINISHED* is {{Application
which finished successfully}}. If its successful and the diagnostic message set
from YARN then thought we should avoid returning it, else we need again handle
this part in {{JobStatus.getFailureInfo}}.
> JobStatus#getFailureInfo should not output diagnostic information when the
> job is running
> -----------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6579
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6579
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Reporter: Rohith Sharma K S
> Assignee: Naganarasimha G R
> Priority: Blocker
> Attachments: MAPREDUCE-6579.01.patch, MAPREDUCE-6579.02.patch,
> MAPREDUCE-6579.03.patch, MAPREDUCE-6579.04.patch, MAPREDUCE-6579.05.patch,
> MAPREDUCE-6579.06.patch, MAPREDUCE-6579.07.patch
>
>
> From
> [https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt]
> TestNetworkedJob are failed intermittently.
> {code}
> Running org.apache.hadoop.mapred.TestNetworkedJob
> Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 81.131 sec
> <<< FAILURE! - in org.apache.hadoop.mapred.TestNetworkedJob
> testNetworkedJob(org.apache.hadoop.mapred.TestNetworkedJob) Time elapsed:
> 30.55 sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[[Tue Dec 15 14:02:45 +0000 2015]
> Application is Activated, waiting for resources to be assigned for AM.
> Details : AM Partition = <DEFAULT_PARTITION> ; Partition Resource =
> <memory:8192, vCores:16> ; Queue's Absolute capacity = 100.0 % ; Queue's
> Absolute used capacity = 0.0 % ; Queue's Absolute max capacity = 100.0 % ; ]>
> but was:<[]>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hadoop.mapred.TestNetworkedJob.testNetworkedJob(TestNetworkedJob.java:174)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
