[
https://issues.apache.org/jira/browse/MAPREDUCE-7136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609054#comment-16609054
]
Oleksandr Shevchenko commented on MAPREDUCE-7136:
-------------------------------------------------
Patch attached.
Could someone kindly review the patch?
Thanks.
> TestMRAppMetrics should shutdown DefaultMetricsSystem after completion
> ----------------------------------------------------------------------
>
> Key: MAPREDUCE-7136
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7136
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Reporter: Oleksandr Shevchenko
> Priority: Minor
> Attachments: MAPREDUCE-7136.001.patch,
> image-2018-09-10-14-39-57-992.png
>
>
> TestMRAppMetrics should invoke shutdown method in DefaultMetricsSystem after
> completion. Since it can lead to failing other tests. For example,
> TestRMContainerAllocator#testReportedAppProgress fails when run after
> TestMRAppMetrics#testNames with the following error:
> {noformat}
> org.apache.hadoop.metrics2.MetricsException: Metrics source MRAppMetrics
> already exists!
> {noformat}
> !image-2018-09-10-14-39-57-992.png!
> We do not catch this on the trunk since the test
> TestRMContainerAllocator#testUnsupportedMapContainerRequirement run first and
> "DefaultMetricsSystem.shutdown();" invokes after completion. But since JUnit
> does not guarantee the order of the tests we should fix it.
> Also, this is affected by previous versions which run testReportedAppProgress
> first (I faced it on 2.7.0 version).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
