[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611082#comment-16611082
 ] 

Hudson commented on MAPREDUCE-7136:
-----------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14923 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14923/])
MAPREDUCE-7136. TestMRAppMetrics should shutdown DefaultMetricsSystem (jlowe: 
rev 598380ad5a1dbcd8168dad45a84beceb90a91d0c)
* (edit) 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/metrics/TestMRAppMetrics.java


> TestMRAppMetrics should shutdown DefaultMetricsSystem after completion
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7136
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7136
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Oleksandr Shevchenko
>            Assignee: Oleksandr Shevchenko
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: MAPREDUCE-7136.001.patch, 
> image-2018-09-10-14-39-57-992.png
>
>
> TestMRAppMetrics should invoke shutdown method in DefaultMetricsSystem after 
> completion. Since it can lead to failing other tests. For example, 
> TestRMContainerAllocator#testReportedAppProgress fails when run after 
> TestMRAppMetrics#testNames with the following error:
> {noformat}
> org.apache.hadoop.metrics2.MetricsException: Metrics source MRAppMetrics 
> already exists!
> {noformat}
> !image-2018-09-10-14-39-57-992.png!
> We do not catch this on the trunk since the test 
> TestRMContainerAllocator#testUnsupportedMapContainerRequirement run first and 
> "DefaultMetricsSystem.shutdown();" invokes after completion. But since JUnit 
> does not guarantee the order of the tests we should fix it. 
>  Also, this is affected by previous versions which run 
> testReportedAppProgress first (I faced it on 2.7.0 version). And reproduced 
> on the trunk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to