[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611076#comment-16611076
 ] 

Oleksandr Shevchenko commented on MAPREDUCE-7136:
-------------------------------------------------

{quote}
However it's important to note problems like this are likely to keep cropping 
up since JVM reuse for separate test classes is not regularly tested.
{quote}
[~jlowe] Can I open the ticket and propose a patch if I faced tests which fail 
if run in one JVM? Or better disregard it? Probably, we have many tests with 
the same problems and I'm worried that I will create many tickets and it's will 
looks like a spam :)


> TestMRAppMetrics should shutdown DefaultMetricsSystem after completion
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7136
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7136
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Oleksandr Shevchenko
>            Assignee: Oleksandr Shevchenko
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: MAPREDUCE-7136.001.patch, 
> image-2018-09-10-14-39-57-992.png
>
>
> TestMRAppMetrics should invoke shutdown method in DefaultMetricsSystem after 
> completion. Since it can lead to failing other tests. For example, 
> TestRMContainerAllocator#testReportedAppProgress fails when run after 
> TestMRAppMetrics#testNames with the following error:
> {noformat}
> org.apache.hadoop.metrics2.MetricsException: Metrics source MRAppMetrics 
> already exists!
> {noformat}
> !image-2018-09-10-14-39-57-992.png!
> We do not catch this on the trunk since the test 
> TestRMContainerAllocator#testUnsupportedMapContainerRequirement run first and 
> "DefaultMetricsSystem.shutdown();" invokes after completion. But since JUnit 
> does not guarantee the order of the tests we should fix it. 
>  Also, this is affected by previous versions which run 
> testReportedAppProgress first (I faced it on 2.7.0 version). And reproduced 
> on the trunk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to