Completed. https://github.com/jonswar/perl-mason/pull/16#commits-pushed-bdd2292
Docs, tests and code. It should fix all reported problems, and the behaviour is actually much saner than before. Comments? Bye, On Mon, Jan 7, 2013 at 1:36 PM, Pedro Melo <[email protected]> wrote: > Done > > https://github.com/jonswar/perl-mason/pull/16#commits-pushed-baa1643 > > Jonathan, its not read yet, need to update the docs. Lunch time around > here, I'll do that when I get back. > > The original fix for #8 was overly eager and caused this bug. I think > the new patch is much better, simpler to understand. > > Bye, > > On Mon, Jan 7, 2013 at 1:05 PM, Oliver Paukstadt <[email protected]> > wrote: >> On Mon, 2013-01-07 at 12:21 +0000, Pedro Melo wrote: >>> Hi, >>> >>> On Mon, Jan 7, 2013 at 7:13 AM, Jonathan Swartz <[email protected]> wrote: >>> > >>> > On Jan 6, 2013, at 1:03 PM, Oliver Paukstadt <[email protected]> >>> > wrote: >>> >>> >>> >> There is a test for this case as far as I understand line 104 in >>> >> Mason-2.20/lib/Mason/t/ResolveURI.pm correct. But this one is designed >>> >> wrong in my eyes. It fits the implementation, not what was reality >>> >> before the 2.20 release and what is reasonable and expected. >>> >>> No. That test is for dhandler + index presence. >>> >> Line 101 in your fork, looks like Jon did some cleanup since 2.20 >> release. >> Does this test conflict with the new check in line 107? >> >> Regards, >> Oliver Paukstadt >> -- >> Oliver Paukstadt <[email protected]> >> > > > > -- > Pedro Melo > @pedromelo > http://www.simplicidade.org/ > http://about.me/melo > xmpp:[email protected] > mailto:[email protected] -- Pedro Melo @pedromelo http://www.simplicidade.org/ http://about.me/melo xmpp:[email protected] mailto:[email protected] ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 _______________________________________________ Mason-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mason-users
