>> if (x > 0.0 && x < *xm) *xm = x; >> if (y > 0.0 && y < *ym) *ym = y; >> } >> } >> >> >> In the last 2 lines, why are xm and ym being clipped at 0, when x0 and >> y0 are not? > xm and ym are the minimum positive values, used for log scales. > Definitely worth a comment.
I will add one. >> >> 2) It looks like update_path_extents throws away orientation by always >> returning x0 and y0 as the minima. Bbox.update_from_path is therefore >> doing the same. This doesn't hurt in present usage, since orientation >> is not needed for dataLim, but it seems a bit surprising, and worth a >> comment at least. Am I again missing something obvious? >> > I think I'm missing something. (Choices in my code are always obvious > to *me*, and any mistakes are invisible... ;) Are you suggesting that > if a line has x decreasing then x0 > x1? What if it boomerangs? I > think it's simplest to keep data limits in a consistent order. View > limits are another issue, of course. I think I will add a comment. The only "problem" at present is that update_from_path, taken as a perfectly general Bbox method, is doing a bit more than is obvious from its name or even from the code, and this places at least a theoretical restriction on its potential use. For example, if someone looked at the method and thought he or she could use it to directly update a viewLim, the result would not be as expected. Eric > > Mike > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
