> From: Alan Cox [mailto:[email protected]] > Sent: Monday, January 03, 2011 11:03 PM > To: Joseph Lai/WHQ/Wistron > Cc: [email protected] > Subject: Re: [Meego-kernel] [RFC/PATCH 0/9] mpu3050/6000: add support > forInvenSense mpu3050/6000 Gyroscope chip > > > Would anyone kindly give me some comments about this driver? > > I will very appreciate that. > > Definitely needs work but the core of it looks like it can be tidied up > into a nice kernel driver for upstream. Only had a quick pass over it > at this point and a brief scan of the documents so more exploration > will be needed. > > Obvious starting points I think would be > > - Remove some of the ioctls that can be handled via sysfs (do we in > fact need most of the char devices ?)
Chip vendor provides a MPL (motion processing library) to control the micro-processor on chip via ioctl. (MPL includes some patent motions, dynamic firmware and algorithms for gyroscope, accelerometer and e-compass.) On the other hand, sensor framework in meego will communicate with device via sysfs to get raw data and control power mode. So, in this patch, the driver keeps these two interfaces. Could meego kernel accept this? > - Register the I²C bus as a kernel I²C bus when not being used by the > device (would allow sharing of standard I²C drivers for modules like > compasses off it In this driver, the part of accelerometer and compass collocates with core of gyroscope driver, because this is an auxiliary component for gyroscope, which needs this component to fix the drift of gyroscope. This architecture is designed for MPL. (Does this answer your question?) > - Style wise remove various wrappers, fix for Linux style and comment > style (probably best done as a last item) > - Possibly use request_firmware for the uploads to the device ? The firmware update is already implemented in MPL, so the function name might not be changed. > > But the basics and the input device it provides all looks pretty much > like I'd expect it to work and appear. > > Alan _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
