On 1/4/2011 1:52 AM, [email protected] wrote:
From: Alan Cox [mailto:[email protected]]
Sent: Monday, January 03, 2011 11:03 PM
To: Joseph Lai/WHQ/Wistron
Cc: [email protected]
Subject: Re: [Meego-kernel] [RFC/PATCH 0/9] mpu3050/6000: add support
forInvenSense mpu3050/6000 Gyroscope chip
Would anyone kindly give me some comments about this driver?
I will very appreciate that.
Definitely needs work but the core of it looks like it can be tidied up
into a nice kernel driver for upstream. Only had a quick pass over it
at this point and a brief scan of the documents so more exploration
will be needed.
Obvious starting points I think would be
- Remove some of the ioctls that can be handled via sysfs (do we in
fact need most of the char devices ?)
Chip vendor provides a MPL (motion processing library) to control the
micro-processor on chip via ioctl. (MPL includes some patent motions, dynamic
firmware and algorithms for gyroscope, accelerometer and e-compass.)
On the other hand, sensor framework in meego will communicate with device via
sysfs to get raw data and control power mode.
So, in this patch, the driver keeps these two interfaces.
Could meego kernel accept this?
unfortunately not.
new userspace interfaces like this would need to be accepted by the
upstream kernel first, and this is not the sort of thing that they would
accept. The MPL library will need to be adjusted to the proper sysfs
interface instead.
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
