On Tue, Nov 22, 2016 at 2:19 PM, Danek Duvall <danek.duv...@oracle.com> wrote:
> Gregory Szorc wrote: > > > On Tue, Nov 22, 2016 at 1:34 PM, <danek.duv...@oracle.com> wrote: > > > > > # HG changeset patch > > > # User Danek Duvall <danek.duv...@oracle.com> > > > # Date 1479850325 28800 > > > # Tue Nov 22 13:32:05 2016 -0800 > > > # Node ID b09fb7f66e9e680358b8fb359be24a14fd6b3cfb > > > # Parent 8836f13e3c5b8eae765372708b659c55a044cbb4 > > > zstd: fix compilation with Solaris Studio > > > > > > Without these changes, Solaris Studio (12.4) gives us "syntax error: > empty > > > declaration" on these two lines. > > > > > > > Doh. > > > > This patch LGTM. I've applied this upstream as well and it will be in the > > next python-zstandard release. The canonical upstream is > > https://github.com/indygreg/python-zstandard by the way (although I > haven't > > pushed the fix there yet). > > Cool. FWIW, the mercurial build didn't fail when I got this failure, which > I found a bit surprising. I get the desire to make sure that the zstd > support isn't critical, but if I hadn't known to go look for this, I would > have missed it entirely until at some point I checked to see that the zstd > bits were, in fact, being delivered. There's probably a happy medium > somewhere. > Uhh - that shouldn't happen! distutils does support optional extensions, but we don't have that flag set in setup.py. When I `make local` or `python setup.py build_ext` with a "bad" .c file from python-zstandard/c-ext, I get an "error: command 'gcc' failed with exit status 1" and setup.py aborts. I'm really curious what your machine is up to!
_______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
