On 11/23/2016 03:45 AM, Yuya Nishihara wrote:
On Tue, 22 Nov 2016 14:07:51 -0800, Gregory Szorc wrote:
On Tue, Nov 22, 2016 at 1:34 PM, <danek.duv...@oracle.com> wrote:
# HG changeset patch
# User Danek Duvall <danek.duv...@oracle.com>
# Date 1479850325 28800
# Tue Nov 22 13:32:05 2016 -0800
# Node ID b09fb7f66e9e680358b8fb359be24a14fd6b3cfb
# Parent 8836f13e3c5b8eae765372708b659c55a044cbb4
zstd: fix compilation with Solaris Studio
Without these changes, Solaris Studio (12.4) gives us "syntax error: empty
declaration" on these two lines.
Doh.
This patch LGTM. I've applied this upstream as well and it will be in the
next python-zstandard release. The canonical upstream is
https://github.com/indygreg/python-zstandard by the way (although I haven't
pushed the fix there yet).
Queued this, thanks.
Just for reference, this kind of error can be found by CFLAGS=-pedantic with
gcc.
Should we run our continuous integration build (or even default build)
with that option to catch such errors earlier?
Cheers,
--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
