Gregory Szorc wrote:
> > Cool. FWIW, the mercurial build didn't fail when I got this failure, which
> > I found a bit surprising. I get the desire to make sure that the zstd
> > support isn't critical, but if I hadn't known to go look for this, I would
> > have missed it entirely until at some point I checked to see that the zstd
> > bits were, in fact, being delivered. There's probably a happy medium
> > somewhere.
> >
>
> Uhh - that shouldn't happen!
>
> distutils does support optional extensions, but we don't have that flag set
> in setup.py. When I `make local` or `python setup.py build_ext` with a
> "bad" .c file from python-zstandard/c-ext, I get an "error: command 'gcc'
> failed with exit status 1" and setup.py aborts. I'm really curious what
> your machine is up to!
Oh. Because it's a *warning*, so the exit code is 0. Here's the full
error:
".../compressionparams.c", line 139: warning: syntax error: empty
declaration
The module didn't show up in my manifest because the new manifest wasn't
generated due to (hopefully unrelated) test failures.
So uh, the patch isn't critical, but we could still do without the warning.
Now to figure out the test failures. :-/ I should really get that
buildbot instance up so it's not all on me. :)
Thanks,
Danek
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
