Following discussion with marmoute on IRC, I'll drop the rawrevision() method for now.
On Fri, 30 Dec 2016 at 11:12 Augie Fackler <r...@durin42.com> wrote: > > > On Dec 30, 2016, at 10:46 AM, Rémi Chaintron <remi.chaint...@gmail.com> > wrote: > > > > The actual rawrevision() method is simply a personal preference as I > like to have simpler apis on operations with optional arguments and I've > seen this in other places, but I do not feel strongly about moving it to > use the raw argument in calls to revision directly. Let me know what you > prefer. > > https://silkandspinach.net/2004/07/15/avoid-boolean-parameters/ > > In this particular case, my opinion is that it’s a clear win to avoid the > boolean parameter since raw=False is actually defined in terms of raw=True, > so it makes sense to express the one case in terms of the other using a > function call to expose the structure to the reader. > > Not a requirement, but that’s my reasoning for the choice. :) -- Rémi
_______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
