Alphare added inline comments. INLINE COMMENTS
> marmoute wrote in status.rs:29-38 > I am curious about where this changes comes from? did rust-format changed > opinion or did we reached a threshold? I was fixing conflicts and prefer this style. `rustfmt` does not nest already separate imports. If that's an issue I suppose I can change it. > marmoute wrote in status.rs:241 > Does this TODO affect the "readiness" of this code to be used in production ? > If not, can you clarify what that TODO implies ? Clarified in the updated inline comment. I mainly wanted to avoid even more code that had very little chance of being useful. If you disagree, please let me know. > marmoute wrote in status.rs:656 > What's the implication of this comment ? (or rephrase, the consequence on not > having that "done" yet?) Oops, it's "insensitive", not "sensitive". REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7929/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7929 To: Alphare, #hg-reviewers Cc: marmoute, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
