marmoute added inline comments. INLINE COMMENTS
> Alphare wrote in status.rs:29-38 > I was fixing conflicts and prefer this style. `rustfmt` does not nest already > separate imports. If that's an issue I suppose I can change it. This is not an issue, but this add noise that distract from the core of the patch. Consider doing this kind og small change in independant changesets. > Alphare wrote in status.rs:241 > Clarified in the updated inline comment. I mainly wanted to avoid even more > code that had very little chance of being useful. If you disagree, please let > me know. It is still not very clear to me. Do we have BadType case where it would make sense to use somethign else than Unknown? > Alphare wrote in status.rs:656 > Oops, it's "insensitive", not "sensitive". So, right now, the status code do now work on case insensitive file system. I assume the proper gards are in place at a higher level ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7929/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7929 To: Alphare, #hg-reviewers Cc: marmoute, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
